Worker Cleanup #815
Merged
Worker Cleanup #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided to open this PR because I was at a point where I made a few small changes and everything still compiled... I figured I might as well get this merged already to have a nicer diff in consecutive PRs where I'll try and unit test the upload manager.
The nice thing about these changes is that the upload and download managers are initialised in the same way, with all of their dependencies being nice clean interfaces. This PR adds a (temporary) interface called the
ObjectStore. It's temporary because I might split it off into more granular interfaces down the road.Next step is to mock the
Host,HostManager,MemoryManagerandObjectStorewhich allow us to unit test both uploads and downloads.